This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
refactor(experimental): export every type from the sham #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 17, 2023
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
steveluscher
force-pushed
the
11-16-refactor_experimental_a_sham_for_Keypair
branch
from
f911029 to
69ba06a
Compare
steveluscher
force-pushed
the
11-17-refactor_experimental_export_every_type_from_the_sham
branch
from
b53582e to
e5be20d
Compare
lorisleiva
reviewed
Nov 18, 2023
| ConfirmedTransaction, | ||
| ConfirmedTransactionMeta, | ||
| ConfirmOptions, | ||
| Connection, |
There was a problem hiding this comment.
I think it's fair to do that for pure types but maybe not for classes since new Connection() here will fail in a very confusing way.
There was a problem hiding this comment.
Oh, I remove types from this array as I implement the shams for them. Connection is what I'm doing today.
lorisleiva
approved these changes
Nov 20, 2023
steveluscher
force-pushed
the
11-16-refactor_experimental_a_sham_for_Keypair
branch
from
69ba06a to
b575706
Compare
steveluscher
force-pushed
the
11-17-refactor_experimental_export_every_type_from_the_sham
branch
from
e5be20d to
ffe4c15
Compare
Merge activity
|
steveluscher
force-pushed
the
11-16-refactor_experimental_a_sham_for_Keypair
branch
from
b575706 to
40a9bea
Compare
Base automatically changed from
11-16-refactor_experimental_a_sham_for_Keypair
to
master
November 20, 2023 21:55
steveluscher
force-pushed
the
11-17-refactor_experimental_export_every_type_from_the_sham
branch
from
ffe4c15 to
8cf4098
Compare
steveluscher
deleted the
11-17-refactor_experimental_export_every_type_from_the_sham
branch
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1825.